This repository was archived by the owner on May 15, 2025. It is now read-only.
forked from kubernetes-sigs/gateway-api-inference-extension
-
Notifications
You must be signed in to change notification settings - Fork 5
[DO NOT MERGE] Renamed Scheduler APIs to better reflect their usage. #116
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a way to enable the PDFilter
Signed-off-by: Jing Chen <[email protected]>
Update pod labels to match those supplied by ModelService
add log lines
- added tokenizer lib linking - go package pulling from neuralmagic internal repo
feat: Add the invocation of the Post response plugins
…that it is called for request processing
…o better indicate that it is invoked for response processing. Refactored function to separate out explicit PostResponse handling.
elevran
suggested changes
May 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to not change Schedule, but rather add another interface type (ie and not a function on an existing interface) for doing the response processing.
/hold |
9ef49b8
to
5ee8225
Compare
@shmuelk - please close as this is being worked on in other PRs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR renames the two APIs of the Scheduler. In particular:
In addition the code in the function Scheduler.OnResponse that is specific to PostResponse plugin handling has been moved to a new private function Scheduler.runPostResponsePlugins, in the style of th functions that drive the handling of the other plugins.